add migration guide #1939

sokra · 2018-03-21T16:35:50Z

No description provided.

nveenjain · 2018-03-28T04:45:31Z

src/content/guides/migrating.md

+``` diff
+mode: "development",
+```
+


Also, we can pass mode: none, right?

montogeek · 2018-06-26T17:19:50Z

@EugeneHlushko You may want to add something here?

EugeneHlushko · 2018-07-18T12:57:20Z

src/content/guides/migrating.md

+
+## module.loaders
+
+`module.loaders` was deprecated since webpack 2 and is now removed in favor of `module.rules`.


were deprecated

EugeneHlushko · 2018-07-18T12:57:53Z

src/content/guides/migrating.md

+
+## json and loaders
+
+When using a custom loader to transform `.json` files you now need to change the module type:


EugeneHlushko · 2018-07-18T13:03:12Z

src/content/guides/migrating.md

+
+## import() and CommonJS
+
+When using `import()` to load non-ESM the result has changed in webpack 4. You now need access the `default` property to get the value of `module.exports`.


Now you need to access the default property to get the value of module.exports.
non-esm.js

module.exports = { sayHello: () => { console.log('hello world') } };

example.js

function sayHello() { import('./non-esm.js').default.sayHello(); } sayHello();

EugeneHlushko · 2018-07-18T13:04:19Z

src/content/guides/migrating.md

+
+## CommonsChunkPlugin
+
+The `CommonsChunkPlugin` was removed. Instead the `optimization.splitChunks` options can be used.


optimization.splitChunks

its getting auto formatted, but i suggest adding links to the docs.

EugeneHlushko · 2018-07-18T13:05:56Z

src/content/guides/migrating.md

+
+## node.js 4
+
+If you are still using node.js 4 or lower, you need to upgrade your node.js installation


EugeneHlushko · 2018-07-18T13:06:57Z

sorry for notification spam, didnt use review feature! will push a commit to adress those points i've added

# Conflicts: # src/content/migrate/3.md

montogeek · 2018-07-18T15:47:35Z

src/content/migrate/3.md

@@ -1,6 +1,6 @@
 ---
-title: To webpack v2, v3
-sort: 1
+title: To v2, v3


I don't understand previous title, neither this one. It is too cryptic :D

when you open the page it makes sense: https://webpack.js.org/migrate/

montogeek · 2018-07-18T15:47:47Z

src/content/migrate/4.md

@@ -0,0 +1,158 @@
+---
+title: To v4 from v3


We should keep titles consistent.

EugeneHlushko · 2018-07-19T06:51:25Z

@montogeek updated

montogeek · 2018-07-23T20:42:47Z

Thanks!

add migration guide

dc072b6

This was referenced Mar 21, 2018

Adds v3 to v4 migration guide #1941

Closed

[Dependency: Guides] - Add v4 Migration Guide #1934

Closed

TheLarkInn mentioned this pull request Mar 21, 2018

[Dependency: Guides] - Create "Migrating" section and move content from Guides #1933

Closed

4 tasks

montogeek added New Release Guides labels Mar 21, 2018

nveenjain reviewed Mar 28, 2018

View reviewed changes

src/content/guides/migrating.md Outdated

``` diff

+mode: "development",

```

Copy link

Member

nveenjain Mar 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we can pass mode: none, right?

edmorley mentioned this pull request Apr 20, 2018

Update to webpack 4 neutrinojs/neutrino#809

Merged

4 tasks

EugeneHlushko reviewed Jul 18, 2018

View reviewed changes

EugeneHlushko self-assigned this Jul 18, 2018

EugeneHlushko added 2 commits July 18, 2018 18:12

Merge branch 'master' into content/migration-4

a570154

# Conflicts: # src/content/migrate/3.md

docs(guides) Migrate v3 to v4

7c848bb

EugeneHlushko force-pushed the content/migration-4 branch from 8ee8768 to 7c848bb Compare July 18, 2018 15:45

montogeek reviewed Jul 18, 2018

View reviewed changes

src/content/migrate/4.md

@@ -0,0 +1,158 @@

---

title: To v4 from v3

Copy link

Member

montogeek Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep titles consistent.

docs(guides) Make migration guide titles consistent

e3ab76f

sokra and others added 3 commits July 20, 2018 12:36

Merge branch 'master' into content/migration-4

8691f8e

Merge branch 'master' into content/migration-4

41273df

Merge branch 'master' into content/migration-4

9b6c80d

montogeek approved these changes Jul 23, 2018

View reviewed changes

montogeek merged commit bdc7fae into master Jul 23, 2018

montogeek deleted the content/migration-4 branch July 23, 2018 20:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add migration guide #1939

add migration guide #1939

sokra commented Mar 21, 2018

nveenjain Mar 28, 2018

montogeek commented Jun 26, 2018

EugeneHlushko Jul 18, 2018

EugeneHlushko Jul 18, 2018

EugeneHlushko Jul 18, 2018

EugeneHlushko Jul 18, 2018

EugeneHlushko Jul 18, 2018

EugeneHlushko Jul 18, 2018

EugeneHlushko commented Jul 18, 2018

montogeek Jul 18, 2018

EugeneHlushko Jul 18, 2018

montogeek Jul 18, 2018

EugeneHlushko commented Jul 19, 2018

montogeek commented Jul 23, 2018


		## module.loaders

		`module.loaders` was deprecated since webpack 2 and is now removed in favor of `module.rules`.


		## json and loaders

		When using a custom loader to transform `.json` files you now need to change the module type:


		## import() and CommonJS

		When using `import()` to load non-ESM the result has changed in webpack 4. You now need access the `default` property to get the value of `module.exports`.


		## CommonsChunkPlugin

		The `CommonsChunkPlugin` was removed. Instead the `optimization.splitChunks` options can be used.


		## node.js 4

		If you are still using node.js 4 or lower, you need to upgrade your node.js installation

add migration guide #1939

add migration guide #1939

Conversation

sokra commented Mar 21, 2018

Choose a reason for hiding this comment

montogeek commented Jun 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EugeneHlushko commented Jul 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EugeneHlushko commented Jul 19, 2018

montogeek commented Jul 23, 2018