Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign correct records and cache to child compilations #4704

Merged
merged 1 commit into from
May 16, 2017

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 13, 2017

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
no

If relevant, link to documentation update:
N/A

Summary
fixes #2777
creating a child compiler now assigns correct cache and records
compiler name is made relative

Does this PR introduce a breaking change?
yes
This is a breaking change because plugins or loader could rely on this incorrect behavior

Other information
When using child compilations plugins and loaders should use a unique compiler name or use a consistent order

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

This is a breaking change because plugins or loader could rely on this incorrect behavior
When using child compilations plugins and loaders should use a unique compiler name or use a consistent order

fixes #2777
@StevenDoesStuffs
Copy link

When will this be merged? It looks like webpack-contrib/extract-text-webpack-plugin#389 will be fixed afterward. (I don't mean to rush anybody, I just want to know whether I should wait for this to happen soon)

@sokra
Copy link
Member Author

sokra commented May 6, 2017

It will be merged into the next major version.

@sokra sokra changed the base branch from master to next May 16, 2017 10:03
@sokra sokra merged commit ee541d9 into next May 16, 2017
@sokra sokra deleted the bugfix/child-records-cache branch May 16, 2017 12:35
joshwiens pushed a commit to webpack-contrib/extract-text-webpack-plugin that referenced this pull request Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants