Disable e1061c5 as it might be unexpected/breaking with eslint v8

webpro-nl · Sep 1, 2024 · 9e67622 · 9e67622
1 parent 0021ff0
commit 9e67622
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/knip/src/plugins/eslint/helpers.ts b/packages/knip/src/plugins/eslint/helpers.ts
@@ -18,7 +18,8 @@ const getDependencies = (config: ESLintConfig | OverrideConfig) => {
     ? getDependenciesFromConfig(config.parserOptions.babelOptions)
     : [];
   const settings = config.settings ? getDependenciesFromSettings(config.settings) : [];
-  const rules = getDependenciesFromRules(config.rules);
+  // const rules = getDependenciesFromRules(config.rules); // TODO enable in next major? Unexpected/breaking in certain cases w/ eslint v8
+  const rules = getDependenciesFromRules({});
   const overrides: string[] = config.overrides ? [config.overrides].flat().flatMap(getDependencies) : [];
 
   return compact([...extendsSpecifiers, ...plugins, parser, ...babelDependencies, ...settings, ...rules, ...overrides]);

diff --git a/packages/knip/test/plugins/eslint.test.ts b/packages/knip/test/plugins/eslint.test.ts
@@ -34,7 +34,7 @@ test('Find dependencies with the ESLint plugin', async () => {
   assert(issues.unlisted['.eslintrc.js']['eslint-plugin-eslint-plugin']);
   assert(issues.unlisted['.eslintrc.js']['eslint-plugin-import']);
   assert(issues.unlisted['.eslintrc.js']['@org/eslint-plugin-name/typescript']);
-  assert(issues.unlisted['.eslintrc.js']['@other-org/eslint-plugin']);
+  // assert(issues.unlisted['.eslintrc.js']['@other-org/eslint-plugin']);
 
   assert(issues.unlisted['.eslintrc.json']['@babel/plugin-syntax-import-assertions']);
   assert(issues.unlisted['.eslintrc.json']['eslint-config-airbnb']);
@@ -45,7 +45,7 @@ test('Find dependencies with the ESLint plugin', async () => {
 
   assert.deepEqual(counters, {
     ...baseCounters,
-    unlisted: 26,
+    unlisted: 25,
     processed: 4,
     total: 4,
   });