Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug display_all_rdataset_names #1664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bloemenk
Copy link

Bug of wrong result whit a single string as argument was solved by the adding an extra elif option in the method. This elif checks if the argument of the function is of the type 'string'

Bug of wrong result whit a single string as argument was solved by the adding an extra elif option in the method. This elif checks if the argument of the function is of the type 'string'
@bloemenk
Copy link
Author

Hi, I would really like to succeed this pull request. Therefor I would like to ask you some advise on how to solve the value error that appears during the build. I am not sure if it has a correlation with the code I worked on.

@henrykironde
Copy link
Contributor

henrykironde commented Feb 4, 2023

Can you comment some previous output and current output after the patch.

@Nageshbansal
Copy link
Contributor

Hey @bloemenk, let us know if you're still working on this patch, as there is already PR #1667 for this same bug.

@henrykironde
Copy link
Contributor

@pyther-hub can you let us know why your solution differs from this initial suggested solution here? @bloemenk, could you also look at @pyther-hub's solution and let us know what you think?

We shall combine and merge both solutions for authorship purposes if validated by the issue creator, @Nageshbansal.

@pyther-hub
Copy link

@henrykironde much difference is not there I have converted the string value into a list with one element and @bloemenk has removed the for loop if str is the input and copied the code for each element which was written under the for loop
the part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants