Fix: get ngx_array_t element number error #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ngx_http_upsync_server_t *upsync_server; | ||
|
|
||
| ngx_pool_t *pool; // worker common pool, can't be destroyed |
There was a problem hiding this comment.
更换为pool 的优点呢？有没有一种极端的情况，内存一直被吞噬（在增删server 比较频繁的场景下），pool 内存释放是以块为单位？
There was a problem hiding this comment.
删除向pool释放的内存，还能被使用，减少向系统申请、释放内存数。
没打算提交pool的修改，因为通过首次upstream有增删控制，去replace_peers已经很好了。
主要是修复bug：
我把这个删了，再提交一个PR。
There was a problem hiding this comment.
欢迎任何可能的修改哈，探讨选取最优的；还有很多待优化的地方 :-);
@seven-eleven 谢谢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.