Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Test condalock on Pull Request branch #6

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Conversation

weiji14
Copy link
Owner

@weiji14 weiji14 commented Aug 24, 2023

Ensure that the lockfile is generated/updated on the Pull Request branch instead of the main branch, following the change at 0f280e7.

Fixes issue first mentioned at #2 (comment)

The fundamental package for scientific computing with Python. Repo at https://github.com/numpy/numpy
@weiji14 weiji14 self-assigned this Aug 24, 2023
@weiji14
Copy link
Owner Author

weiji14 commented Aug 24, 2023

/condalock

@weiji14
Copy link
Owner Author

weiji14 commented Aug 24, 2023

/condalock

@weiji14
Copy link
Owner Author

weiji14 commented Aug 24, 2023

/condalock

@weiji14
Copy link
Owner Author

weiji14 commented Aug 24, 2023

Eureka! It worked 🎉🎉🎉 Comment at #6 (comment) triggered successful run of conda-lock GitHub Action at https://github.com/weiji14/conda-lock-refresh-demo/actions/runs/5960381305/job/16167588253 🥳

Next phase is to ensure that commenting /condalock on Pull Requests from forks also works. Will also spend some time documenting how to use the workflow at https://github.com/weiji14/conda-lock-refresh-demo/blob/0f280e78657578326ba74d9f13861235661fb2d9/.github/workflows/conda-lock.yml properly.

@weiji14 weiji14 marked this pull request as ready for review August 24, 2023 06:48
@weiji14 weiji14 changed the title 🚧 Test condalock on Pull Request branch 🚀 Test condalock on Pull Request branch Aug 24, 2023
@weiji14 weiji14 merged commit b73eaee into main Aug 24, 2023
@weiji14 weiji14 deleted the test-condalock-pr-branch branch August 24, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants