Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Raise ModuleNotFoundError when xbatcher not installed #37

Merged
merged 2 commits into from
Aug 14, 2022

Conversation

weiji14
Copy link
Owner

@weiji14 weiji14 commented Aug 14, 2022

Ensure that a helpful ModuleNotFoundError is raised when attempting to use XbatcherSlicer without xbatcher being installed.

Patches #22

Left out on adding this if-statement in #22. So here's the patch!
Need to use the full name xarray.DataArray instead of xr.DataArray to have the intersphinx link work.
@weiji14 weiji14 added the bug Something isn't working label Aug 14, 2022
@weiji14 weiji14 added this to the 0.3.0 milestone Aug 14, 2022
@weiji14 weiji14 self-assigned this Aug 14, 2022
@weiji14 weiji14 marked this pull request as ready for review August 14, 2022 21:21
@weiji14 weiji14 merged commit b871702 into main Aug 14, 2022
@weiji14 weiji14 deleted the patch/xbatcher_modulenotfounderror branch August 14, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant