Allow Override attribute to be used in pure contexts

Fixes vimeo#10731
weirdan · Feb 21, 2024 · 3cd9658 · 3cd9658
1 parent c401490
commit 3cd9658
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/stubs/CoreGenericAttributes.phpstub b/stubs/CoreGenericAttributes.phpstub
@@ -1,17 +1,20 @@
 <?php
 
+/** @psalm-immutable */
 #[Attribute(Attribute::TARGET_CLASS)]
 final class AllowDynamicProperties
 {
     public function __construct() {}
 }
 
+/** @psalm-immutable */
 #[Attribute(Attribute::TARGET_METHOD)]
 final class Override
 {
     public function __construct() {}
 }
 
+/** @psalm-immutable */
 #[Attribute(Attribute::TARGET_PARAMETER)]
 final class SensitiveParameter
 {

diff --git a/tests/OverrideTest.php b/tests/OverrideTest.php
@@ -68,6 +68,23 @@ public function f(): void;
                 'ignored_issues' => [],
                 'php_version' => '8.3',
             ],
+            'canBeUsedOnPureMethods' => [
+                'code' => <<<'PHP'
+                    <?php
+                    class A {
+                        /** @psalm-pure */
+                        public function f(): void {}
+                    }
+                    class B extends A {
+                        /** @psalm-pure */
+                        #[Override]
+                        public function f(): void {}
+                    }
+                    PHP,
+                'assertions' => [],
+                'ignored_issues' => [],
+                'php_version' => '8.3',
+            ],
         ];
     }