Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/report time to train #100

Merged
merged 13 commits into from
Oct 28, 2021
Merged

Feature/report time to train #100

merged 13 commits into from
Oct 28, 2021

Conversation

aCampello
Copy link
Contributor

@aCampello aCampello commented Oct 25, 2021

Fixes #100.

Note that you'll have to do dvc repro (I did it for scibert/tf-idf), but that will take ages, so not sure how to proceed.

@aCampello aCampello marked this pull request as ready for review October 26, 2021 08:59
@nsorros
Copy link
Contributor

nsorros commented Oct 26, 2021

I can pick it up and run dvc repro or we can merge it and run before we merge XLinear

def get_ec2_instance_type():
"""Utility function to get ec2 instance name, or empty string if not possible to get name"""

instance_type_request = requests.get('http://169.254.169.254/latest/meta-data/instance-type')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a static ip? 169.254.169.254 I think this might be changing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, you are accessing that information from the instance itself not internet. Makes sense, this is a good find btw.

dvc.yaml Outdated
@@ -12,7 +12,7 @@ stages:
- data/processed/science_grants_tagged_title_synopsis.jsonl
train_tfidf_svm:
cmd: grants_tagger train data/processed/science_grants_tagged_title_synopsis.jsonl
models/label_binarizer-2020.05.2.pkl models/tfidf-svm-2020.05.2.pkl --approach tfidf-svm
models/label_binarizer-2020.05.2.pkl models/tfidf-svm-2020.05.2.pkl --approach tfidf-svm --metrics-path results/tfidf_svm_train.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe I would name it train_info to be even more clear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 02aa805

@nsorros
Copy link
Contributor

nsorros commented Oct 28, 2021

This is ready to be merged. I need to run dvc repro which I will do once the current experiment finishes.

Update

dvc repro running

@nsorros
Copy link
Contributor

nsorros commented Oct 28, 2021

dvc repro finished and now we have metrics on how much time it takes to train, thanks @aCampello. It turns out it takes the same amount of time to train Bert in the science dataset and XLinear to Mesh which is amazing for XLinear. The whole thing seems to have taken ~8hr which is good to know.

@nsorros nsorros merged commit 1dc573b into master Oct 28, 2021
@nsorros nsorros deleted the feature/report_time_to_train branch October 28, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants