Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated content is not reflected on the View screen even after refreshing the page #9086

Conversation

miya
Copy link
Member

@miya miya commented Sep 10, 2024

Task

  • #153759 ページを更新しても View 画面に更新内容が反映されない

@miya miya self-assigned this Sep 10, 2024
Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: aa2a343

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -81,8 +83,11 @@ export const useSWRxCurrentPage = (initialData?: IPagePopulatedToShowRevision|nu
return true;
}

// mutate When a different revision is opened
if (cachedData.revision?._id != null && initialData.revision?._id != null && cachedData.revision._id !== initialData.revision._id) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ページ更新時にもここが実行され、最後に getServerSideProps が実行された時 (対象ページに遷移時) の initialData が入ってしまうことで、ページ更新時に古い revisionBody が View に表示されてしまっていた。

@@ -57,6 +57,8 @@ export const useTemplateBodyData = (initialData?: string): SWRResponse<string, E
export const useSWRxCurrentPage = (initialData?: IPagePopulatedToShowRevision|null): SWRResponse<IPagePopulatedToShowRevision|null> => {
const key = 'currentPage';

const { data: isLatestRevision } = useIsLatestRevision();

const { cache } = useSWRConfig();

// Problem 1: https://github.com/weseek/growi/pull/7772/files#diff-4c1708c4f959974166c15435c6b35950ba01bbf35e7e4b8e99efeb125a8000a7
Copy link
Member

@yuki-takei yuki-takei Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここの Problem 列挙コメントにこの問題へのリンクも追加した方がよさそう

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

追加しました

Copy link
Member Author

@miya miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify queue

Copy link
Member Author

@miya miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify queue

@yuki-takei
Copy link
Member

@mergify queue

Copy link
Contributor

mergify bot commented Sep 11, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1d54c77

mergify bot added a commit that referenced this pull request Sep 11, 2024
@mergify mergify bot merged commit 1d54c77 into master Sep 11, 2024
16 checks passed
@mergify mergify bot deleted the fix/153770-updated-content-is-not-reflected-on-the-view-screen-even-after-refreshing-the-page branch September 11, 2024 04:10
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants