fix: Subtasks #35
Open
fix: Subtasks #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e including priority or links for each task. Still needs tests.
…ail how the subtask query logic works.
…stic to automate making it all consistant.
wesmoncrief
reviewed
Mar 11, 2024
| subtaskQuery = "subtask"; // default pull query of all subtasks, regardless of due date | ||
| } else if (todaysSubtasks && !noDateSubtasks) { | ||
| subtaskQuery = "subtask & due: today"; // limits to only subtasks with due date of today | ||
| } else { |
There was a problem hiding this comment.
i think the nesting here gets a bit harder to follow. if you could flatten the ifs, that'd be nice
| } | ||
| )); | ||
| new Setting(subtaskDiv) | ||
| .setName('Limit Subtasks by due date assigned') |
There was a problem hiding this comment.
Suggested change
| .setName('Limit Subtasks by due date assigned') | |
| .setName('Only show subtasks that are due today') |
i think something along these lines is more clear
| )); | ||
| new Setting(this.containerEl) | ||
| .setName('Link') | ||
| .setDesc("Include Link to task in Todoist.") |
There was a problem hiding this comment.
So the toggleServerTaskStatus function currently requires the link in order to work. I don't think we want to have this option silently break task toggling. So let's remove until we find a way to handle linking the source task to server task without the URL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #34. Doing some additional final touches before ready for PR.