spdm_version: add version select support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to select the spdm data message version used by the libspdm responder. The default (as before) is version 1.3. We can now select versions 1.0..=1.3. This is sub-argument to the response command, usage as below: ``` $ spdm_utils --qemu-server response --spdm-ver 1.3 ``` Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
twilfredo
changed the title
|
Note: 1.3 is implicitly selected by libspdm when version is unspecified but is also has some kinks to work out, i.e: DMTF/libspdm#2282 (comment) |
alistair23
approved these changes
Nov 3, 2023
1.0 fails on key-exchange I think that's expected given |
Yep, that was the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to select the spdm data message version used by the libspdm responder. The default (as before) is version 1.3. We can now select versions 1.0..=1.3.
This is sub-argument to the response command, usage as below:
Tested by running get-version request on a responder with version 1.0, 1.1, 1.2, 1.3. Note that, 1.0 fails on key-exchange, likely due to mismatched secure version. Will investigate.