Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tock-responder: libtock-rs: Bump to the latest commit #35

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

alistair23
Copy link
Collaborator

No description provided.

@twilfredo
Copy link
Collaborator

for nrf52840, we need this change in libtock-rs twilfredo/libtock-rs@924d277

Do you think we could upstream something like this for the above:

    #[cfg(feature = "default_layout")]
    ("nrf52840"           , "0x00040000", "768K"     , "0x20008000", "56K"    ),
    #[cfg(feature = "big_heap")]
    ("nrf52840"           , "0x00040000", "768K"     , "0x20010000", "128K"    ),

@alistair23
Copy link
Collaborator Author

The RAM size in libtock-rs should match the board. So if there is 128K of RAM we can update it in libtock-rs, no need for a cfg flag

@twilfredo
Copy link
Collaborator

The RAM size in libtock-rs should match the board. So if there is 128K of RAM we can update it in libtock-rs, no need for a cfg flag

I thought this was the RAM size allocated for the app slice, so if we bump it to the max size then only 1 app can be loaded at a time. Is that wrong?

@alistair23
Copy link
Collaborator Author

That would depend on the board. If one app uses all the RAM then yes, you can only have one. But I don't think there is any point in artificially limiting application sizes. We can only run a single libtock-rs application anyway (without modifying addresses).

@twilfredo
Copy link
Collaborator

That would depend on the board. If one app uses all the RAM then yes, you can only have one. But I don't think there is any point in artificially limiting application sizes. We can only run a single libtock-rs application anyway (without modifying addresses).

okay sounds good, I'll send a patch.

@twilfredo
Copy link
Collaborator

Do you wanna bump this commit to the latest latest master, it has the RNG api that just merged?

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
@alistair23 alistair23 merged commit 2568c7f into master Jan 11, 2024
@alistair23 alistair23 deleted the alistair/libtock-rs-update branch January 11, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants