manifest: add improved cbor manifest support with cbor-diag
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
twilfredo
force-pushed
the
wilfred/fixup-manifest-support
branch
2 times, most recently
from
8be6693
to
8d1686d
Compare
alistair23
reviewed
Feb 29, 2024
Use the `cbor-diag` ruby gem instead of CBOR2 to manifest encoding and decoding. It seems to encode and decode more accurately over the CBOR2 module. Manifests serialized by CBOR2 could not be properly decoded by `cbor.me`. Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
twilfredo
force-pushed
the
wilfred/fixup-manifest-support
branch
from
8d1686d
to
0352371
Compare
alistair23
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Integrates cbor-diag support to
spdm-utils. This allows us to better encode/decode the cbor manifests. This allows us to reproduce similar results to that ofhttps://cbor.me/site.README has been updated to add required build instructions, we no longer depends on
CBOR2as well.New Features
When building
spdm-utilsit will now use themanifest/manifest.in.cborfile to create two files, a serialised cbor file (manifest.out.cbor) and one in pretty format (manifest.pretty). The hex stream can be retrieved withxxd -p manifest.out.cbor.When handling a
get-measurementsrequest, the requester will now decode and display the responders measurement manifest in both the pretty and the diagnostic formats intostdout. See image below:manifest/responder_manifest.cborandmanifest/responder_manifest.pretty. The aim is for these to be used to test for correctness/compliance of the manifest.