libspdm: spdm: Don't double count measurements #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The measurement helper functions (like libspdm_fill_measurement_image_hash_block()) already include the spdm_measurement_block_dmtf_t size and the length of the data in the return value. There is no need to calculate it twice. This commit removes the second attempt to calculate total_size_needed. This fixes the wrong size being reported if changes are made to the measurement functions. Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
twilfredo
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The measurement helper functions (like
libspdm_fill_measurement_image_hash_block()) already include the spdm_measurement_block_dmtf_t size and the length of the data in the return value. There is no need to calculate it twice.
This commit removes the second attempt to calculate total_size_needed. This fixes the wrong size being reported if changes are made to the measurement functions.