libspdm: responder: Support PSK with ResponderContext #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently advertise that we support
Pre-Shared Key but does not provide ResponderContext for session key derivation.
Let's update this to instead advertise
Pre-Shared Key and provides ResponderContext for session key derivation
The SPDM spec states that:
the Responder is required to use ResponderContext if it can generate a nonce
which we can, so let's adertise ResponderContext.
This also allows the libspdm function libspdm_get_response_psk_finish() to
work correctly.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
twilfredo
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently advertise that we support
Let's update this to instead advertise
As the SPDM spec states that:
which we can, so let's advertise ResponderContext.
This also allows the libspdm function libspdm_get_response_psk_finish() to work correctly.