Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for evm_setAccountCode #2636

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

saeta-eth
Copy link
Contributor

@saeta-eth saeta-eth commented Aug 20, 2024

This PR introduces the evm_setAccountCodefrom Ganache to Viem, integrating it into the existing setCode function.

Related PR: trufflesuite/ganache#2337


PR-Codex overview

The focus of this PR is to add support for evm_setAccountCode in the setCode action and update method names in eip1193.ts.

Detailed summary

  • Added support for evm_setAccountCode in setCode action in setCode.ts
  • Updated method names to use single quotes in eip1193.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: a66004f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 20, 2024

@saeta-eth is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@saeta-eth saeta-eth changed the title feat: add evm_setAccountCode feat: add support for evm_setAccountCode Aug 20, 2024
Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset with pnpm changeset

pnpm-lock.yaml Outdated Show resolved Hide resolved
@tmm
Copy link
Member

tmm commented Aug 20, 2024

Not actionable for this PR, but might be good to remove ganache support in the next major version as it's recommended to use Hardhat or another tool instead. cc @jxom

@saeta-eth saeta-eth requested a review from tmm August 20, 2024 19:15
@tmm tmm merged commit 5f60093 into wevm:main Aug 20, 2024
2 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants