-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved WV-409- Audited the privacy policy page for ADA compliance issues and made changes to the code to make it ADA compliant. #4011
base: develop
Are you sure you want to change the base?
Conversation
@@ -84,7 +84,7 @@ export default class PrivacyBody extends Component { | |||
programs, and to send you timely election reminders. | |||
You may opt-out of receiving messages from WeVote by sending any email to | |||
{' '} | |||
<a href="mailto:info@WeVote.US" target="_blank" rel="noopener noreferrer">info@WeVote.US</a> | |||
<a href="mailto:info@WeVote.US" target="_blank" class="class u-link-color" rel="noopener noreferrer">info@WeVote.US</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Almee98 thank you for pushing this issue forward! I notice this is where the extra "class " is that I mentioned in our meeting yesterday. (It can be removed)
@@ -322,8 +322,9 @@ export default class PrivacyBody extends Component { | |||
<span> | |||
If you have any questions about this Privacy Policy, you may contact us by sending an e-mail to | |||
{' '} | |||
<a href="mailto:info@WeVote.US" target="_blank" rel="noopener noreferrer">info@WeVote.US</a> | |||
<a href="mailto:info@WeVote.US" target="_blank" class="class u-link-color" rel="noopener noreferrer">info@WeVote.US</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another extra "class " text.
|
||
export default withStyles(styles)(HeaderBackTo); | ||
|
||
import { AccountCircle } from '@mui/icons-material'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Almee, could you please remove this file from your pull request? I don't see any changes, but Github is reacting as if you deleted this file and then added it beck in again. I would recommend spending some time researching how to fix this by searching Google. It might be a little bit complicated, but is worth it to learn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
{' '} | ||
</span> | ||
)} | ||
<Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
{' '} | ||
around | ||
{' '} | ||
<Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
I will | ||
{' '} | ||
{' '} | ||
<Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
with my ballot to my | ||
{' '} | ||
{' '} | ||
<Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
commit: removed src/js/components/Navigation/HeaderBackTo.jsx from the commit.
What github.com/wevote/WebApp/issues does this fix?
Changes included this pull request?
aria-label="profile avatar"
in the profile icon button so that it has a name that is identifiable by screen readers.Changes that might be needed:
`
`If you have any questions about this Privacy Policy, you may contact us by sending an e-mail to
{' '}
info@WeVote.US
{' '}
You can also write to us at the following address:
Is not recognizable even after changing the colors. The only way it is distinguishable is if there is some text that immediately follows 'info@WeVote.US' link.