Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the list of the descendant browsing contexts #5089

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Improve the list of the descendant browsing contexts #5089

merged 2 commits into from
Nov 19, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 15, 2019 •
edited by pr-preview bot
Loading

@annevk annevk added clarification Standard could be clearer topic: shadow Relates to shadow trees (as defined in DOM) labels Nov 15, 2019
@annevk
Copy link
Member Author

annevk commented Nov 15, 2019

This helps with #4409.

@annevk annevk mentioned this pull request Nov 15, 2019
Merged
domenic
domenic approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with potential improvements.

Please fix second commit message to stay under the limit, though.

source Show resolved Hide resolved
source Show resolved Hide resolved
@annevk annevk merged commit 37af7d9 into master Nov 19, 2019
@annevk annevk deleted the annevk/nested-through-1 branch November 19, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
clarification Standard could be clearer topic: shadow Relates to shadow trees (as defined in DOM)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @domenic