-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import assertions integration #5883
Import assertions integration #5883
Commits on Jun 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 914e7d5 - Browse repository at this point
Copy the full SHA 914e7d5View commit details -
Add import attribute type checks and initial plumbing.
Update all [[RequestedModules]] references to reflect the change from string to ModuleRequest. Pass ModuleRequest instead of url to 'internal module graph fetching procedure'. Add optional ModuleRequest param to 'fetch a single module script'. Add checks in 'fetch a single module script' to fail if the type doesn't match.
Configuration menu - View commit details
-
Copy full SHA for b058240 - Browse repository at this point
Copy the full SHA b058240View commit details -
Plumb through ModuleRequest instead of string for 'fetch an import() …
…module script graph', HostResolveImportedModule, and HostResolveImportedModuleDynamically.
Configuration menu - View commit details
-
Copy full SHA for d0137f5 - Browse repository at this point
Copy the full SHA d0137f5View commit details -
Don't cache a null entry in the module map in the case where the MIME…
… type is valid but doesn't match the requested type.
Configuration menu - View commit details
-
Copy full SHA for b2e7065 - Browse repository at this point
Copy the full SHA b2e7065View commit details -
Allow modulepreload to work for all module types without needing to s…
…pecify type at the point of preload. Achieve this by adding 'module type must match' flag to 'fetch a single module script', which is unset only in the case of modulepreload.
Configuration menu - View commit details
-
Copy full SHA for 0cbf597 - Browse repository at this point
Copy the full SHA 0cbf597View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6932074 - Browse repository at this point
Copy the full SHA 6932074View commit details
Commits on Jun 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1f83c7e - Browse repository at this point
Copy the full SHA 1f83c7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3621dd - Browse repository at this point
Copy the full SHA a3621ddView commit details -
Revert added null check in 'fetch a modulepreload module script graph…
…'; I'll add this in a separate PR.
Configuration menu - View commit details
-
Copy full SHA for 55ebd12 - Browse repository at this point
Copy the full SHA 55ebd12View commit details -
Reference ParseJSONModule from import-attributes proposal instead of …
…defining steps in HTML spec
Configuration menu - View commit details
-
Copy full SHA for af41b28 - Browse repository at this point
Copy the full SHA af41b28View commit details
Commits on Jun 23, 2020
-
Cache an entry in the module map if the fetched module was valid but …
…does not match the type specified at the import site.
Configuration menu - View commit details
-
Copy full SHA for a2d4260 - Browse repository at this point
Copy the full SHA a2d4260View commit details -
Extend note to be clear that the module must have no effect until a r…
…equest matches its type and it is evalutated
Configuration menu - View commit details
-
Copy full SHA for f79c01f - Browse repository at this point
Copy the full SHA f79c01fView commit details
Commits on Jun 25, 2020
-
When a valid MIME type is received that doesn't match the requested t…
…ype, cache the fetch response instead of creating and caching the module script. The module script is created only when there is a type match. This addreses concerns that parsing modules (perhaps even types of modules that don't yet exist) could have side-effects.
Configuration menu - View commit details
-
Copy full SHA for 7c900a1 - Browse repository at this point
Copy the full SHA 7c900a1View commit details
Commits on Jun 26, 2020
-
Wrap <p class=note> in <li> so it's not directly under an <ol>, which…
… the Travis CI build doesn't like.
Configuration menu - View commit details
-
Copy full SHA for 55c9ed9 - Browse repository at this point
Copy the full SHA 55c9ed9View commit details -
Whitespace change: remove double spaces after sentences in notes. Hop…
…efully unstick CI build, which seems to be stuck.
Configuration menu - View commit details
-
Copy full SHA for 322808d - Browse repository at this point
Copy the full SHA 322808dView commit details
Commits on Jun 30, 2020
-
Merge branch 'upstream-master' into dandclark/import-attributes
Resolve many merge conflicts in /source.
Configuration menu - View commit details
-
Copy full SHA for 43e6fe3 - Browse repository at this point
Copy the full SHA 43e6fe3View commit details -
Reword invocations of 'create a module script with matching type' to …
…ensure they are synchronous with respect to the calling 'fetch a single module script'
Configuration menu - View commit details
-
Copy full SHA for 9f2ae27 - Browse repository at this point
Copy the full SHA 9f2ae27View commit details -
Change 'fetch a single module script' to fail if there are any unreco…
…gnized import attributes, and assert that there is only one of key 'type' (which should be guaranteed by Ecma262)
Configuration menu - View commit details
-
Copy full SHA for e86dd65 - Browse repository at this point
Copy the full SHA e86dd65View commit details
Commits on Jul 7, 2020
-
Instead of passing fetch response parameter to 'create a module scrip…
…t with matching type', retrieve it from the module map within the algorithm.
Configuration menu - View commit details
-
Copy full SHA for 3318ed3 - Browse repository at this point
Copy the full SHA 3318ed3View commit details -
Add assert that 'create a module script with matching type' is not ru…
…nning in parallel
Configuration menu - View commit details
-
Copy full SHA for 3c0dce2 - Browse repository at this point
Copy the full SHA 3c0dce2View commit details
Commits on Jul 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1c9df5a - Browse repository at this point
Copy the full SHA 1c9df5aView commit details
Commits on Jul 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3247e99 - Browse repository at this point
Copy the full SHA 3247e99View commit details
Commits on Jul 24, 2020
-
Update for the latest rename of the proposal from 'Import Conditions'…
… to 'Import Assertions'
Configuration menu - View commit details
-
Copy full SHA for dca376b - Browse repository at this point
Copy the full SHA dca376bView commit details
Commits on Jul 27, 2020
-
Use module type as part of module map cache key instead of caching re…
…sponse body in the case of a failed type check.
Configuration menu - View commit details
-
Copy full SHA for e3359b5 - Browse repository at this point
Copy the full SHA e3359b5View commit details
Commits on Aug 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0857ec8 - Browse repository at this point
Copy the full SHA 0857ec8View commit details -
Change 'abort these steps' to 'return' to match recent changes in 'fe…
…tch a single module script'.
Configuration menu - View commit details
-
Copy full SHA for aafb256 - Browse repository at this point
Copy the full SHA aafb256View commit details
Commits on Aug 31, 2020
-
Remove JSON modules references, switch JavaScript module script refer…
…ences back to just 'module script'
Configuration menu - View commit details
-
Copy full SHA for 9164acf - Browse repository at this point
Copy the full SHA 9164acfView commit details
Commits on Sep 30, 2020
-
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
…attributes-no-json
Configuration menu - View commit details
-
Copy full SHA for f53c203 - Browse repository at this point
Copy the full SHA f53c203View commit details -
Update module map dfn note to explain purpose of having module type i…
…n key, and that in practice fetches and module evalutations will only occur once per specifier
Configuration menu - View commit details
-
Copy full SHA for 73f2be2 - Browse repository at this point
Copy the full SHA 73f2be2View commit details -
Ignore unknown import assertions instead of failing. Continue failing…
… for unrecognized types (which is to say, any type at all).
Configuration menu - View commit details
-
Copy full SHA for 6ed4474 - Browse repository at this point
Copy the full SHA 6ed4474View commit details
Commits on Oct 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c225d56 - Browse repository at this point
Copy the full SHA c225d56View commit details
Commits on Nov 12, 2020
-
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
…attributes-no-json
Configuration menu - View commit details
-
Copy full SHA for 1566bc0 - Browse repository at this point
Copy the full SHA 1566bc0View commit details -
Review feedback: use tuple instead of pair, improve module map defini…
…tion, use 'javascript' instead of undefined, fix indents.
Configuration menu - View commit details
-
Copy full SHA for 3c94b31 - Browse repository at this point
Copy the full SHA 3c94b31View commit details
Commits on Nov 13, 2020
-
Review feedback: Link to memory cache issue, null --> 'javascript' ty…
…pe, misc whitespace issues.
Configuration menu - View commit details
-
Copy full SHA for 9da92b5 - Browse repository at this point
Copy the full SHA 9da92b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26c2b81 - Browse repository at this point
Copy the full SHA 26c2b81View commit details
Commits on Nov 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4ad7d2d - Browse repository at this point
Copy the full SHA 4ad7d2dView commit details
Commits on Nov 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 614a9f4 - Browse repository at this point
Copy the full SHA 614a9f4View commit details
Commits on Dec 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2fc3616 - Browse repository at this point
Copy the full SHA 2fc3616View commit details
Commits on Dec 11, 2020
-
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
…attributes-no-json
Configuration menu - View commit details
-
Copy full SHA for 697a6f1 - Browse repository at this point
Copy the full SHA 697a6f1View commit details
Commits on Dec 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a9eed9b - Browse repository at this point
Copy the full SHA a9eed9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 973ec71 - Browse repository at this point
Copy the full SHA 973ec71View commit details
Commits on Dec 31, 2020
-
Clarify that memory cache mitigating violation of import assertions s…
…pec recommendation is not a sure thing.
Configuration menu - View commit details
-
Copy full SHA for fdc08f8 - Browse repository at this point
Copy the full SHA fdc08f8View commit details
Commits on Mar 10, 2021
-
Merge remote-tracking branch 'upstream/main' into dandclark/import-at…
…tributes-no-json
Configuration menu - View commit details
-
Copy full SHA for 30e27fb - Browse repository at this point
Copy the full SHA 30e27fbView commit details
Commits on Mar 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9ec7c7e - Browse repository at this point
Copy the full SHA 9ec7c7eView commit details