Remove node-fetch from peerDependencies since it is optional #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch-mock v7 added a peer dependency on `node-fetch`, however the package is not required for browser-based usages of fetch-mock. Such projects must then either install the dependency even if they don't use it, or else have peer dependency warnings be output by their package manager. Hopefully in the future package managers will have a way to declare optional peer dependencies (eg yarnpkg/yarn#6487), so version ranges can be enforced iff people are using the dependency - but for now it's best to omit them from `peerDependencies` entirely. Fixes #377.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch-mock v7 added a peer dependency on
node-fetch, however the package is not required for browser-based usages of fetch-mock. Such projects must then either install the dependency even if they don't use it, or else have peer dependency warnings be output by their package manager.Hopefully in the future package managers will have a way to declare optional peer dependencies (eg yarnpkg/yarn#6487), so version ranges can be enforced iff people are using the dependency - but for now it's best to omit them from
peerDependenciesentirely.Fixes #377.