[WFCORE-6685] CLIEmbedServerTestCase.testStdOutEcho fails intermittently #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
yersan
reviewed
Feb 22, 2024
Comment on lines
738
to
739
| } else { | ||
| Thread.sleep(20); | ||
| } |
There was a problem hiding this comment.
Thanks for adding this, although I would suggest a longer pause, let's say 1 second or half one. Using TimeUnit makes it more readable, but that's also completely optional e.g TimeUnit.MILLISECONDS.sleep(500)
The else can be removed since the break will do the work, that's optional too.
None of these notes would prevent merging it as it is, so I leave it up to you to apply the changes. Otherwise, I will approve and merge
There was a problem hiding this comment.
Thanks for review @yersan, I have added suggested changes.
yersan
approved these changes
Feb 22, 2024
yersan
added
the
ready-for-merge
|
Thanks @lvydra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6685