Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-6801] Use maven.compiler.release to ensure the desired binary… #5976

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Apr 22, 2024

… compilation level

It also removes the maven.compiler.target and maven.compiler.source properties since they will be replaced by the --release option supported by the maven compiler plugin 3.6. The maven compiler plugin version is inherited from the jboss-parent maven module, so maven.compiler.release will be available for the project. Behind scenes, the maven compiler plugging should be ignoring the --target and --source options when --release is in place since target/source is not compatible with release

Jira issue: https://issues.redhat.com/browse/WFCORE-6801

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Apr 22, 2024
@yersan yersan requested a review from jamezp April 23, 2024 08:52
@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Apr 25, 2024
@yersan yersan merged commit b9b48d6 into wildfly:main Apr 25, 2024
12 checks passed
@yersan
Copy link
Collaborator Author

yersan commented Apr 25, 2024

Thanks @jamezp

@yersan yersan deleted the WFCORE-6801 branch April 25, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants