Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-6807 Prune deprecations from wildfly-service and wildfly-subsystem #6045

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

pferraro
Copy link
Contributor

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jun 21, 2024
@darranl
Copy link
Contributor

darranl commented Jun 21, 2024

As this module is relatively new it is probably too new that these removals will cause issues but how do we determine when it is safe to remove deprecations like this?

Subsystems and feature packs can be developed outside of the WildFly and WildFly Core repos and may not be keeping up to date at the same cadence as WildFly.

@wildfly-ci

This comment was marked as off-topic.

@pferraro
Copy link
Contributor Author

As this module is relatively new it is probably too new that these removals will cause issues but how do we determine when it is safe to remove deprecations like this?

Subsystems and feature packs can be developed outside of the WildFly and WildFly Core repos and may not be keeping up to date at the same cadence as WildFly.

FWIW, the methods being removed here were introduced in 23.0.0.Final and deprecated for removal in 24.0.0.Final.
There is only one external repo of which I am aware that uses wildfly-service/subsystem (https://github.com/wildfly-extras/mvc-krazo-feature-pack), and it is unaffected.
I think it would be unwise to delay these removals too long lest they end up in a downstream release.

Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agreed with Paul on this, so I approved from my side

@darranl Do you still have concerns with these removals?

@yersan yersan requested a review from darranl June 25, 2024 11:50
@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jun 27, 2024
@yersan yersan merged commit 076db39 into wildfly:main Jun 27, 2024
12 checks passed
@yersan
Copy link
Collaborator

yersan commented Jun 27, 2024

Thanks @pferraro @darranl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25.x deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants