WFCORE-6883 Upgrade to jboss-logging 3.6.0 / jboss-logging-tools 3.0.0 #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, marko-bekhta. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. |
|
/ok-to-test |
github-actions
bot
added
the
deps-changed
|
Core -> Full Integration Build 13641 outcome was FAILURE using a merge of d2b49c1 |
|
Core -> Full Integration Build 13927 outcome was FAILURE using a merge of d2b49c1 |
|
Core -> WildFly Preview Integration Build 13712 outcome was FAILURE using a merge of d2b49c1 |
|
Hello @marko-bekhta / @jamezp correct me if I am wrong, but wildfly-common 2.0.0 requires JDK 17, so we won't be able to upgrade until we move WildFly requirements out of JDK 11 See https://issues.redhat.com/browse/WFCORE-6856, which is indeed a duplicate |
|
I think this will likely need to wait for WF 34 (dev starts in < 2 weeks) as the need to update a plugin makes it seem this is risky. |
This is fine with me. The main reason I've started this PR is that the currently developed Hibernate Search and Hibernate Validator are using jboss-logging 3.6, and if the WildFly doesn't upgrade then we won't be able to upgrade Search/Validator too (in WildFly). BTW on a related note, Hibernate Validator 9.0 will require Java 17 as the Jakarta Validation spec (https://jakarta.ee/specifications/bean-validation/3.1/) requires it... |
bstansberry
reviewed
Jul 6, 2024
marko-bekhta
force-pushed
the
jboss-logging-upgrade
branch
from
d2b49c1
to
8652038
Compare
|
Core -> Full Integration Build 13644 outcome was FAILURE using a merge of 8652038 |
|
Core -> Full Integration Build 13930 outcome was FAILURE using a merge of 8652038 |
|
Core -> WildFly Preview Integration Build 13715 outcome was FAILURE using a merge of 8652038 |
jamezp
requested changes
Jul 8, 2024
marko-bekhta
force-pushed
the
jboss-logging-upgrade
branch
from
8652038
to
778e667
Compare
marko-bekhta
changed the title
OK, I've realized that that was a wrong assumption on my side 🙈. For some reason, I thought that since wf-common has a dependency on wf-logging, I should bump wf-common to the version using the wf-logging version we want to update to 🤦🏻♂️ 😃. |
|
Core -> Full Integration Build 13650 outcome was FAILURE using a merge of 778e667 |
|
Core -> WildFly Preview Integration Build 13722 outcome was FAILURE using a merge of 778e667 |
|
Core -> Full Integration Build 13937 outcome was FAILURE using a merge of 778e667 |
|
Thank you @marko-bekhta! I'll need to look more into the failures, but I won't be able to until next week. If we need a new release of the wildfly-maven-plugin I can do that too. However, I'm not seeing the same issue on other projects so I want to do a little research on this. |
|
/retest |
|
Core -> Full Integration Build 14030 outcome was FAILURE using a merge of 778e667 |
|
Core -> Full Integration Build 13741 outcome was FAILURE using a merge of 778e667 |
|
Core -> WildFly Preview Integration Build 13815 outcome was FAILURE using a merge of 778e667 |
|
Core -> WildFly Preview Integration Build 13832 outcome was FAILURE using a merge of c9877f3 Failed tests |
|
Core -> Full Integration Build 14048 outcome was FAILURE using a merge of c9877f3 Failed tests |
|
This failure is due to |
|
/retest |
|
Core -> WildFly Preview Integration Build 13833 outcome was FAILURE using a merge of c9877f3 Failed tests |
|
I'm looking into the failure with the bootable JAR. The error starts in the |
Hey @jamezp , can I ask whether your investigation reached a conclusion? I'm asking because, as you know, if the next WF release is not going to include JBoss Logging 3.6, we may need to delay Hibernate upgrades in WildFly (https://issues.redhat.com/browse/WFLY-19632 / https://issues.redhat.com/browse/WFLY-19306) or find workarounds. |
|
@yrodiere I started looking at it and some other things got in the way. I'll make this a priority for this week though. I'm not sure yet what the issue is, but it seems to be a Windows only issue. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Core -> WildFly Preview Integration Build 13899 outcome was FAILURE using a merge of c9877f3 Failed tests |
|
Core -> WildFly Preview Integration Build 13902 outcome was FAILURE using a merge of c9877f3 Failed tests |
jamezp
requested changes
Aug 28, 2024
| @@ -433,6 +433,7 @@ public void undeploy(DeploymentUnit context) { | |||
| } | |||
| String message = ServerLogger.ROOT_LOGGER.unsuccessfulBoot(String.join(" ", messages)); | |||
| bootstrapListener.bootFailure(new Exception(message, cause)); | |||
| cause.printStackTrace(); | |||
There was a problem hiding this comment.
This needs to be removed as it can cause an NPE and I believe that is the issue with the test failures.
There was a problem hiding this comment.
rebased and removed this line
…ing an exception parameter - the RuntimeOperationsException constructors require parameters. Without a "fake" parameter the generation of the logger will fail
marko-bekhta
force-pushed
the
jboss-logging-upgrade
branch
from
c9877f3
to
27859b2
Compare
|
Core -> Full Integration Build 13839 outcome was FAILURE using a merge of 27859b2 Failed tests |
jamezp
added
the
ready-for-merge
|
Thanks @marko-bekhta @jamezp |
|
Thanks 😃 |
|
Hey @marko-bekhta , you can track this wildfly/wildfly#18156 |
|
ohh it's already out, nice! 😃 thanks for the pointer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6883
Hey @jamezp 👋🏻 😃
It's probably easier to look at the patch by commit.
JmxLoggerwhere the exception requires at least an exception as a parameter, so I've updated the interface to include it. (later updated according to @kabir suggestion)wildfly-maven-pluginrequires overriding the logging dependency as it pulls the previous one, and with all the changes for the new API, the build fails if the dependency is not overridden...