Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6892] Remove duplicate plugin declaration #6068

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[WFCORE-6892] Remove duplicate plugin declaration #6068

merged 1 commit into from
Jul 11, 2024

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Jul 10, 2024

@yersan yersan requested a review from kabir July 10, 2024 15:09
@yersan yersan added the 25.x label Jul 10, 2024
@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jul 10, 2024
@wildfly-ci
Copy link

Core -> Full Integration Build 13657 outcome was FAILURE using a merge of 36ddb5b
Summary: Tests passed: 169, ignored: 4; exit code 1 (Step: Test full with JDK 11 (Maven)) (new) Build time: 00:19:09

kabir
kabir approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@kabir kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built the branch and can confirm there is no warning, and the tests using this feature pack still pass

@yersan yersan added ready-for-merge This PR is ready to be merged and fulfills all requirements and removed ready-for-merge This PR is ready to be merged and fulfills all requirements labels Jul 10, 2024
@yersan yersan merged commit 23f9000 into wildfly:main Jul 11, 2024
11 of 12 checks passed
@yersan
Copy link
Collaborator Author

yersan commented Jul 11, 2024

Thanks @kabir

@yersan yersan deleted the WFCORE-6892 branch July 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabir kabir kabir approved these changes

Assignees
No one assigned
Labels
25.x deps-ok Dependencies have been checked, and there are no significant changes ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yersan @wildfly-ci @kabir