[WFCORE-6895] Add a grace period to Management CLI Installer Windows … #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
spyrkob
reviewed
Jul 16, 2024
| @@ -89,3 +89,6 @@ if ($HOST_CONTROLLER_JAVA_OPTS -eq $null) { | |||
| # Sample JPDA settings for shared memory debugging | |||
| #PROCESS_CONTROLLER_JAVA_OPTS="$PROCESS_CONTROLLER_JAVA_OPTS -agentlib:jdwp=transport=dt_shmem,server=y,suspend=n,address=jboss" | |||
| #HOST_CONTROLLER_JAVA_OPTS="$HOST_CONTROLLER_JAVA_OPTS -agentlib:jdwp=transport=dt_shmem,server=y,suspend=n,address=jboss" | |||
There was a problem hiding this comment.
Not connected to this PR, but should those assignments start with $sign (e.g. $HOST_CONTROLLER_JAVA_OPTS)?
There was a problem hiding this comment.
Good catch!, variables in Powershell are defined starting the with $, I'll append a commit
spyrkob
reviewed
Jul 16, 2024
| @@ -177,11 +176,6 @@ protected void doHandle(CommandContext ctx) throws CommandLineException { | |||
|
|
|||
| if(isLocalClient) { | |||
| ctx.printLine("The JBoss CLI session will be closed automatically to allow the server be updated. Once the server has been restarted, you can relaunch the JBoss CLI session.", false); | |||
| try { | |||
There was a problem hiding this comment.
The wait in the startup scripts only applies to Windows scripts, but this wait happened also on Linux - is that OK to remove it?
There was a problem hiding this comment.
@spyrkob thanks for commenting on it. It does nothing, it just waits a bit to have a better UX; you execute the command and see how it waits a bit with the message printed, that's all. It is safe to close it immediately.
spyrkob
approved these changes
Jul 16, 2024
yersan
added
the
ready-for-merge
|
Thanks @spyrkob |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…script
Jira issue: https://issues.redhat.com/browse/WFCORE-6895
This just adds a configurable grace period to help prevent locking file errors on Windows when using Management CLI Installer