WFCORE-6930 Remove usage of deprecated AbstractWriteAttributeHandler constructors in testsuite #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constructors in testsuite
github-actions
bot
added
the
deps-ok
bstansberry
requested changes
Jul 19, 2024
| protected BasicAttributeWriteHandler() { | ||
| super(List.of()); | ||
| } | ||
|
|
There was a problem hiding this comment.
@pferraro This class seems wrong; it seems to be adding a new call to a deprecated c'tor instead of removing the existing one.
There was a problem hiding this comment.
Hmm - not sure what I was thinking here. Will fix.
Now I remember...
This operation handler is used for transformer tests. The purpose of the additional no-arg constructor is to migrate the calling code.
However, the no-arg super constructor does not exist on the legacy version of AbstractWriteAttributeHandler, hence the need to delegate to a super constructor that does exist.
bstansberry
approved these changes
Jul 22, 2024
bstansberry
added
the
ready-for-merge
|
Thanks @pferraro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6930