-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFCORE-6663 Introduce AttributeDefinition implementations to wildfly-subsystem that can resolve directly to a ServiceDependency #6123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
Dependencies have been checked, and there are no significant changes
label
Aug 6, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pferraro
force-pushed
the
WFCORE-6663
branch
3 times, most recently
from
August 8, 2024 16:26
751be09
to
f0e41e3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pferraro
force-pushed
the
WFCORE-6663
branch
3 times, most recently
from
August 12, 2024 18:56
4b55f09
to
e04b533
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
pferraro
force-pushed
the
WFCORE-6663
branch
2 times, most recently
from
August 15, 2024 22:27
4917067
to
1c8ab8e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
yersan
reviewed
Sep 11, 2024
...va/org/wildfly/subsystem/resource/capability/CapabilityReferenceListAttributeDefinition.java
Outdated
Show resolved
Hide resolved
pferraro
force-pushed
the
WFCORE-6663
branch
2 times, most recently
from
September 11, 2024 15:42
ba6d74d
to
469c230
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
bstansberry
reviewed
Sep 12, 2024
...n/java/org/wildfly/subsystem/resource/capability/CapabilityReferenceAttributeDefinition.java
Show resolved
Hide resolved
bstansberry
reviewed
Sep 12, 2024
...n/java/org/wildfly/subsystem/resource/capability/CapabilityReferenceAttributeDefinition.java
Show resolved
Hide resolved
bstansberry
reviewed
Sep 12, 2024
...va/org/wildfly/subsystem/resource/capability/CapabilityReferenceListAttributeDefinition.java
Show resolved
Hide resolved
bstansberry
reviewed
Sep 12, 2024
...va/org/wildfly/subsystem/resource/capability/CapabilityReferenceListAttributeDefinition.java
Show resolved
Hide resolved
bstansberry
reviewed
Sep 12, 2024
io/subsystem/src/main/java/org/wildfly/extension/io/IOSubsystemRegistrar.java
Outdated
Show resolved
Hide resolved
@pferraro This looks fine in general (and I know Yeray reviewed it carefully). I made some minor javadoc comments, and then a somewhat more substantial one about IOSubsystemRegistrar, which, if valid should be simple to correct. |
SimpleResource should also have javadoc for methods where it throws OSE. |
pferraro
force-pushed
the
WFCORE-6663
branch
from
September 12, 2024 15:24
81f589b
to
baa4dee
Compare
All missing javadocs added. |
This comment was marked as off-topic.
This comment was marked as off-topic.
…ame collisions with interface from wildfly-controller.
… a model directly to a ServiceDependency.
pferraro
force-pushed
the
WFCORE-6663
branch
from
September 12, 2024 19:44
baa4dee
to
695bb83
Compare
Rebased against main. |
pferraro
force-pushed
the
WFCORE-6663
branch
from
September 13, 2024 08:00
695bb83
to
2e3db4e
Compare
yersan
approved these changes
Sep 13, 2024
yersan
added
the
ready-for-merge
This PR is ready to be merged and fulfills all requirements
label
Sep 13, 2024
Thanks @pferraro @bstansberry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deps-ok
Dependencies have been checked, and there are no significant changes
ready-for-merge
This PR is ready to be merged and fulfills all requirements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6663
e.g.
Within an operation runtime handler, we can use the context of the capability reference to resolve our attribute from the model directly to a ServiceDependency:
If FOO is not required, the resulting ServiceDependency will either return a null, or, if the service descriptor provides alternate default resolution, will result to the default value.
Similarly, as a multi-value attribute, BAR resolves to a service dependency providing an empty list if not required.