WFCORE-6974 Add convenience factory method to create a ServiceDependency from a Supplier. #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
deps-ok
This comment was marked as outdated.
This comment was marked as outdated.
yersan
approved these changes
Sep 3, 2024
yersan
added
the
ready-for-merge
|
Core -> Full Integration Build 14144 outcome was UNKNOWN using a merge of f3aaaf5 |
…ncy from a Supplier.
pferraro
force-pushed
the
WFCORE-6974
branch
from
f476fd1
to
cf61f9e
Compare
|
@yersan FYI - I updated this to additionally validate a non-null supplier, which would otherwise defer the NPE until the returned dependency is used. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6974