Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML spec vscode extension for realtime feedback #104

Draft
wants to merge 133 commits into
base: main
Choose a base branch
from
Draft

YAML spec vscode extension for realtime feedback #104

wants to merge 133 commits into from

Conversation

cisaacstern
Copy link
Collaborator

@cisaacstern cisaacstern commented Jul 26, 2024 •
edited
Loading

Closes #103

🤯

Screenshot 2024-07-26 at 3 46 20 PM
☝️ Here, there is a subtle typo in task: get_subjectgroup_observation (the task name is missing the trailing s) ... and the extension knowns that and is telling us in real time as I edit the file!

@cisaacstern
rewrite compilation spec in a new way
b18a0d3
@cisaacstern
widgets first commit
f2378a5
@cisaacstern
add test for single view widget
8886444
@cisaacstern
test merge widget views
36e6adc
@cisaacstern
test merge views multiple widgets
5a59840
@cisaacstern
widgets WIP
157db97
@cisaacstern
Merge remote-tracking branch 'origin/main' into widgets
8da41c5
@cisaacstern
a little more typing for filters
463a0e3
@cisaacstern
widget typing cont
d6862c3
@cisaacstern
test fix
6ff9a71
@cisaacstern
reorg
9a90078
@cisaacstern
typing differentiation cont
4408822
@cisaacstern
simplify return
918482c
@cisaacstern
merge grouped widgets with inplace or
9635ecc
@cisaacstern
test get_view, and narrow its scope
c6cb515
@cisaacstern
makes more sense for merge_key to be a property of GroupedWidget
ffec4f3
@cisaacstern
split widget creators into separate tasks
beea2a2
@cisaacstern
allow none for view, test all widget creators
2f0c74a
@cisaacstern
recompile seq dag examples with create widget
8e5060d
@cisaacstern
refactor widget tasks to make them work w jupytext
15e8c6f
@cisaacstern
recompile params
ab8b6ba
@cisaacstern
end to end tests
068bab4
@cisaacstern
a little renaming
c9c5fce
@cisaacstern
fix test
3488ef1
@cisaacstern
dashboard first commit
0e45472
@cisaacstern
drop ast parsing
303cf98
@cisaacstern
call tasks directly in jupytext
145b5b5
@cisaacstern
Merge branch 'drop-ast' into widgets
7b5da50
@cisaacstern
with drop ast, remove annoying duplicate imports
7ece200
@cisaacstern
test none views
4373457
@cisaacstern
arg name validation WIP
335a775
@cisaacstern
ids of deps need to be ids of another task
266b853
@cisaacstern
ids instead of task names as variables WIP
6e0c17a
@cisaacstern
jupytext ids
b8b11ad
@cisaacstern
recompile params with id
7a16830
@cisaacstern
update example params
a7e4558
@cisaacstern
fix test
9c65e8a
@cisaacstern
remove completed todo note
ccfa24a
@cisaacstern
spec name constraints
dcdc9b9
@cisaacstern
workflow field desc
bec914b
@cisaacstern
fix test
1255c17
@cisaacstern
add mode
a59333e
@cisaacstern
parallel map WIP first commit
58a73c8
@cisaacstern
manual baseline for map
d794b64
@cisaacstern
recreate mockup with jinja
fd33d92
@cisaacstern
conditional functools import
6efb4c2
@cisaacstern
mode map compilation for jupytext
9cf6a73
@cisaacstern
xfail mode-map e2e tests except generate dag
586db01
@cisaacstern
fix templatename literal
2ad160a
@cisaacstern
Merge remote-tracking branch 'origin/main' into dashboard
40f6fc1
@cisaacstern
enumerated view can inherit from widget base
464e556
@cisaacstern
makes more sense for dashboard to handle view key switching
f72fbab
@cisaacstern
docstrings
7ff5e48
@cisaacstern
Merge branch 'dashboard' into more-verbose-yaml-spec
7907c4f
@cisaacstern
arg dependency arrays WIP
accb506
@cisaacstern
extension first commit
56fa51b
@cisaacstern
Copy link
Collaborator Author

cisaacstern commented Jul 26, 2024 •
edited
Loading

Some next steps:

  • Get language server to start with the currently selected python interpreter in vscode
  • Setup a "hot reload" configuration of the server so that the validation (optionally) evolves as the the Spec model evolves
  • Document an easy way to set this up in your local environment (eventually could be released on marketplace, but that's probably overkill at this point)
  • Use the loc field in the error to backtrack to which line(s) (and possibly columns as well) are causing the error (rather than red-underlining the whole text)
  • Figure out how to have this validation only ecoscope compilation specs (not a all yaml files)
  • Fix all the silly placeholder names in package.json etc.
  • Some lightweight tests

Base automatically changed from more-verbose-yaml-spec to main July 31, 2024 16:36
@cisaacstern cisaacstern mentioned this pull request Aug 4, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCode Extension for live validation of compilation specs
1 participant
@cisaacstern