Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared] Expose tooltip props #79

Merged
merged 5 commits into from
Nov 29, 2017
Merged

Conversation

williaster
Copy link
Owner

@williaster williaster commented Nov 21, 2017

🏆 Enhancements

  • Allows additional customization Adds tooltipProps to the <WithTooltip />which will be passed to its TooltipComponent (and adds example in demo)
    image

  • Exposes @vx/responsive's new observer-based <ParentSize /> HOC

🐛 Bug fix

TODO

  • update readmes to include tooltipProps
  • add tests for new functionality

@williaster williaster added this to the v0.0.49 milestone Nov 21, 2017
@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage decreased (-0.1%) to 83.687% when pulling 78f9e8a on chris--with-tooltip-props into f5d4f42 on master.

@coveralls
Copy link

coveralls commented Nov 28, 2017

Coverage Status

Coverage decreased (-0.1%) to 83.687% when pulling 128b382 on chris--with-tooltip-props into f5d4f42 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.687% when pulling 128b382 on chris--with-tooltip-props into f5d4f42 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.687% when pulling 128b382 on chris--with-tooltip-props into f5d4f42 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 83.687% when pulling 128b382 on chris--with-tooltip-props into f5d4f42 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 84.698% when pulling 268bc64 on chris--with-tooltip-props into f5d4f42 on master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.6%) to 84.408% when pulling 268bc64 on chris--with-tooltip-props into f5d4f42 on master.

@williaster williaster merged commit c5b7c42 into master Nov 29, 2017
@williaster williaster deleted the chris--with-tooltip-props branch November 29, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants