Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Add support and tests for scalars #27

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

API: Add support and tests for scalars #27

wants to merge 1 commit into from

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Mar 28, 2024 •
edited
Loading

Issue: #25

Hi @willow-ahrens @hameerabbasi,

This is a new WIP PR that is meant to introduce support and tests for scalars (the previous one was from my fork that I removed).

For scalars we need to decide if we want to use Scalar or SparseScalar (with customizable default) objects.

@mtsokol mtsokol added the enhancement New feature or request label Mar 28, 2024
@mtsokol mtsokol self-assigned this Mar 28, 2024
@mtsokol mtsokol mentioned this pull request Mar 28, 2024
Closed
@hameerabbasi
Copy link
Collaborator

I think Scalar is better, where default == value. There's no point for a scalar where default != value because that will only densify what could otherwise be a sparse computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtsokol mtsokol

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsokol @hameerabbasi