Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WillowTree_FunctionalCodeReview #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

WillowTree_FunctionalCodeReview #3

wants to merge 6 commits into from

Commits on Dec 6, 2016

  1. 🎉 Add 3rd Party CDNs & Styling 

    + Add CDNs for Bootstrap and new JQuery version
+ Add in-line styling to rendered controls for a more readable UI
    @pgrimail
    pgrimail committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    4fa2adf View commit details
    Browse the repository at this point in the history

  2. 🎨 Replace Inconsistent Function Declaration 

    + Replace function declaration from const to function. There was no
need to use getFirstName as a parameter call, nor as a constant, thus
changing to function declaration.
    @pgrimail
    pgrimail committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    3f12790 View commit details
    Browse the repository at this point in the history

  3. 🔥 Remove slice 

    + Remove slice when copying List array. When slicing, we have no need,
nor want, to remove array objects. This is incorrect functionality and
results in loss of data.
    @pgrimail
    pgrimail committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    21123df View commit details
    Browse the repository at this point in the history

  4. 🐐 Name Search in Real-Time 

    + Remove validation for type & value check between search value and
available names.
+ Add validation to be based on .includes so we now check real-time
against search values. Thus, “A”, will grab any names including “A”.
    @pgrimail
    pgrimail committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    18c46ef View commit details
    Browse the repository at this point in the history

  5. 🐐 Enhance Sort Functionality 

    + Change calls for First/Last Name sorts to specify first/last name
+ Add function parameter for first/last name sort and update function
to sort based on new function parameter.
** Note: Before, using .reverse() on sort last name would only sort
first name descending. As this is incorrect, we need to specify
first/last name sorting.
    @pgrimail
    pgrimail committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    4ca91f0 View commit details
    Browse the repository at this point in the history

  6. 📝 Add Summary Notes of Commit Batch 

    + Add notes related to batch of commits where additional
notes/explanations are needed.
    @pgrimail
    pgrimail committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    986e52a View commit details
    Browse the repository at this point in the history