Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override flavor sources in the given order #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Override flavor sources in the given order #57

wants to merge 1 commit into from

Conversation

cazacutudor
Copy link
Contributor

The problem:
If you have an flavor defined with 2 or more sources, they will be override in reverse direction those given. So source2 will be override by source1, what is confusing for the users.

flavors:
 flavor_name:
    src:
      - source1
      - source2

This pull request will doing flavor source overrides in the given order.

slheavner
slheavner reviewed Dec 3, 2018
View reviewed changes
Copy link
Contributor

@slheavner slheavner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the slow response!

I'm totally for this change, for some reason it made sense to me for reverse order, idk why 😆

Would you mind adding a configuration flag for backwards compatibility? It's fine if not reverse is the default

@cazacutudor
Copy link
Contributor Author

Hi @slheavner, i'm not sure why we still want to support the reversed version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slheavner slheavner slheavner left review comments

@nishtahir nishtahir Awaiting requested review from nishtahir nishtahir is a code owner

@vannuysm vannuysm Awaiting requested review from vannuysm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cazacutudor @slheavner