Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change div to p tag in message list [ACC-24] #14257

Merged
merged 1 commit into from
Dec 5, 2022
Merged

refactor: change div to p tag in message list [ACC-24] #14257

merged 1 commit into from
Dec 5, 2022

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Dec 5, 2022 •
edited by github-actions bot
Loading

StoryACC-24 Info and Relationships - HTML Structure (9.1.3.1)

Issue

  • paragraphs should be provided with a

    tag

Changes

Replace <span>or <div> by <¶> in the following elelments of the message list

  • system messages (call ended, decryption error, enable/disable read receipts, etc)
  • file asset descriptions
  • link descriptions
  • Pings, deleted messages, ...

@V-Gira V-Gira requested review from a team and otto-the-bot as code owners December 5, 2022 15:24
atomrc
atomrc approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@atomrc atomrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, no css changes needed? Nice :)

@V-Gira V-Gira merged commit febd2e4 into dev Dec 5, 2022
@V-Gira V-Gira deleted the virgile/semantic-html-message-list branch December 5, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomrc atomrc atomrc approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
👕 size: S type: refactoring 🛠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@V-Gira @atomrc @otto-the-bot