refactor: Make CallingRepository a little more stateless #14553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomrc
commented
Jan 26, 2023
| @@ -692,7 +692,6 @@ export class CallingRepository { | |||
| const convId = this.serializeQualifiedId(conversationId); | |||
| this.logger.log(`Starting a call of type "${callType}" in conversation ID "${convId}"...`); | |||
| try { | |||
| await this.checkConcurrentJoinedCall(conversationId, CALL_STATE.OUTGOING); | |||
There was a problem hiding this comment.
It's not the responsibility of the CallingRepo to check if there is a call ongoing. This has been moved to the view layer (see CallingViewModel)
atomrc
commented
Jan 26, 2023
| call.currentPage(newPage); | ||
| if (!this.callState.isSpeakersViewActive()) { | ||
| this.requestCurrentPageVideoStreams(); | ||
| this.requestCurrentPageVideoStreams(call); |
There was a problem hiding this comment.
We now inject the call that is concerned with the paging change in order for the CallingRepo not to have to check the state
thisisamir98
approved these changes
Jan 26, 2023
Codecov Report
@@ Coverage Diff @@
## dev #14553 +/- ##
==========================================
+ Coverage 42.24% 42.32% +0.08%
==========================================
Files 612 612
Lines 20919 20912 -7
Branches 4791 4791
==========================================
+ Hits 8837 8852 +15
+ Misses 10973 10945 -28
- Partials 1109 1115 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will move the view-related logic from the calling repository to the view model (where it should have belonged in the first place).
This touches those 2 scenarios:
Answering a call that is ringing when a call is already ongoing in another conversation:
join-incoming.mov
Starting a call while another one is already ongoing:
start-new.mov