Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not show user status in input bar placeholder (ACC-443) #14558

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Jan 27, 2023

StoryACC-443 [Web] Message input bar should have a clear placeholder text instead of showing the user's status

Removed

image

image

We only have type a message now:

image

@thisisamir98 thisisamir98 changed the title feat: Do not sure user status in input bar placeholder (ACC-443) feat: Do not show user status in input bar placeholder (ACC-443) Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #14558 (6cebdef) into dev (fb919da) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev   #14558      +/-   ##
==========================================
- Coverage   42.32%   42.31%   -0.01%     
==========================================
  Files         612      612              
  Lines       20918    20913       -5     
  Branches     4793     4794       +1     
==========================================
- Hits         8853     8849       -4     
  Misses      10950    10950              
+ Partials     1115     1114       -1     

@thisisamir98
Copy link
Contributor Author

Added custom aria-label for self deleting messages placeholder in 6cebdef

image

@thisisamir98 thisisamir98 merged commit a7850b6 into dev Jan 30, 2023
@thisisamir98 thisisamir98 deleted the ACC-443 branch January 30, 2023 16:25
atomrc pushed a commit that referenced this pull request Feb 1, 2023
)

* feat: Do not sure user status in input bar placeholder (ACC-443)

* add aria-label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants