-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correctly match users with umlaut charachters in search (SQSERVICES-1894) #14634
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #14634 +/- ##
=======================================
Coverage 42.60% 42.61%
=======================================
Files 615 616 +1
Lines 21039 21054 +15
Branches 4806 4811 +5
=======================================
+ Hits 8964 8972 +8
- Misses 10959 10966 +7
Partials 1116 1116 |
const property = prop as keyof User; | ||
return typeof userEntity[property] === 'function' | ||
? (userEntity[property] as Function)() | ||
: userEntity[property]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious about why this section changed. id assume including an extra 'as' would be slightly less precisely typed but maybe there was a reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Timothy LeBon <tlebon@gmail.com>
Co-authored-by: Timothy LeBon <tlebon@gmail.com>
Co-authored-by: Timothy LeBon <tlebon@gmail.com>
Co-authored-by: Timothy LeBon <tlebon@gmail.com>
Co-authored-by: Timothy LeBon <tlebon@gmail.com>
With the help of library
speakingurl
when we search the name of the user is converted from "Müge" to "muege" and then we try to match it with the searched value.With this PR we're gonna also convert "Müge" to "muge" and try to match it with the searched value and give it a weight.
Also fixed some TS strict errors along the way.