feat: req_new_epoch advance epoch number #14635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #14635 +/- ##
==========================================
- Coverage 42.60% 42.59% -0.01%
==========================================
Files 615 615
Lines 21041 21040 -1
Branches 4806 4808 +2
==========================================
- Hits 8965 8963 -2
- Misses 10960 10961 +1
Partials 1116 1116 |
przemvs
approved these changes
Feb 7, 2023
atomrc
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AVS library requests new epoch with
req_new_epochcallback, we should advance epoch number by callingcorecrypto.updateKeyingMaterial(groupId)and update epoch info withset_epoch_info.It also reduces some redundant calls to BE subconversation endpoint (we're getting the info from local corecrypto store instead).