Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address unavailable user display issues [FS-1684, FS-1570] #15159

Merged
merged 5 commits into from
May 12, 2023

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented May 11, 2023

Sub-taskFS-1684 [web] Display fallback UI for user profile when user metadata is not available

Sub-taskFS-1570 [web] Show system message indicating who will receive the message later

Issues found in playtest

  • warning message for some unreachable users displays "*empty string*, *empty string* will receive your message later. It should be "2 users from *offline b-e* won't get your message"
  • Conversation title for unreachable user is "...", should be "Name not available"
    image
  • Handles were used in warning message instead of display names

Solutions

  • implement logic to add users with id stored in conversation but no session initiated to the list of unreachable users
  • replace "..." by "Name not available" for 1 on 1 conversation titles (no change to group conversations)
    Screenshot from 2023-05-11 16-57-50
  • replace handle by display name for known users
    image

@V-Gira V-Gira changed the title fix: address issues found in federation playtest [FS-1684] fix: address unavailable user display issues [FS-1684] May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #15159 (a2ff351) into dev (7ded3a7) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev   #15159      +/-   ##
==========================================
+ Coverage   43.15%   43.20%   +0.05%     
==========================================
  Files         644      644              
  Lines       21634    21648      +14     
  Branches     4954     4956       +2     
==========================================
+ Hits         9337     9354      +17     
+ Misses      11105    11102       -3     
  Partials     1192     1192              

@V-Gira V-Gira changed the title fix: address unavailable user display issues [FS-1684] fix: address unavailable user display issues [FS-1684, FS-1570] May 11, 2023
@V-Gira V-Gira marked this pull request as ready for review May 11, 2023 15:10
@V-Gira V-Gira requested review from a team and otto-the-bot as code owners May 11, 2023 15:10
@V-Gira V-Gira merged commit b660bb0 into dev May 12, 2023
@V-Gira V-Gira deleted the virgile/playtest-issues branch May 12, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants