Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Backup Encryption Capability #15433

Merged
merged 25 commits into from
Jul 18, 2023
Merged

Conversation

arjita-mitra
Copy link
Contributor

@arjita-mitra arjita-mitra commented Jul 7, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • Add missing backup encryption capability to web and desktop
  • The PR Description

    • User should be able to encrypt a backup using a password(satisfies our standard password validation). User should be able to save a backup with/without password. If the backup is encrypted then show a popup to enter password.

What's new in this PR?

Issues

  • Backups created by the Wire web client do not offer encryption.

An attacker with access to the backup file can access all backed up conversations in cleartext. In contrast to the desktop or mobile client, the web client does not offer the possibility to create a password protected or otherwise encrypted backup file.

Solutions

As a defense-in-depth measure, a mechanism for creating a backup file, which is protected by a password or is otherwise encrypted should be offered - as is already available for desktop and mobile clients.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

References
  1. https://wearezeta.atlassian.net/browse/WPB-697
  2. https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/59867179/Exporting+history+v3+Kalium+Backups

@arjita-mitra arjita-mitra changed the title Feature/backup encryption feat: Add Backup Encryption Capability Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #15433 (d8eefbc) into dev (cc67d9a) will increase coverage by 0.04%.
The diff coverage is 46.61%.

@@            Coverage Diff             @@
##              dev   #15433      +/-   ##
==========================================
+ Coverage   43.38%   43.43%   +0.04%     
==========================================
  Files         647      649       +2     
  Lines       21833    22076     +243     
  Branches     5019     5048      +29     
==========================================
+ Hits         9473     9589     +116     
- Misses      11134    11254     +120     
- Partials     1226     1233       +7     

src/i18n/en-US.json Outdated Show resolved Hide resolved
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik@wire.com>
package.json Outdated Show resolved Hide resolved
arjita-mitra and others added 6 commits July 17, 2023 15:11
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik@wire.com>
Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com>
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik@wire.com>
Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com>
@arjita-mitra arjita-mitra merged commit a1eb192 into dev Jul 18, 2023
10 checks passed
@arjita-mitra arjita-mitra deleted the feature/backup-encryption branch July 18, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants