-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Backup Encryption Capability #15433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjita-mitra
changed the title
Feature/backup encryption
feat: Add Backup Encryption Capability
Jul 12, 2023
handle modal close button
password mandatory for import if file encrypted
Codecov Report
@@ Coverage Diff @@
## dev #15433 +/- ##
==========================================
+ Coverage 43.38% 43.43% +0.04%
==========================================
Files 647 649 +2
Lines 21833 22076 +243
Branches 5019 5048 +29
==========================================
+ Hits 9473 9589 +116
- Misses 11134 11254 +120
- Partials 1226 1233 +7 |
przemvs
reviewed
Jul 17, 2023
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik@wire.com>
przemvs
reviewed
Jul 17, 2023
przemvs
reviewed
Jul 17, 2023
PatrykBuniX
reviewed
Jul 17, 2023
PatrykBuniX
reviewed
Jul 17, 2023
PatrykBuniX
reviewed
Jul 17, 2023
PatrykBuniX
reviewed
Jul 17, 2023
PatrykBuniX
reviewed
Jul 17, 2023
PatrykBuniX
reviewed
Jul 17, 2023
PatrykBuniX
reviewed
Jul 17, 2023
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik@wire.com>
Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com>
Co-authored-by: Przemysław Jóźwik <przemyslaw.jozwik@wire.com>
Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com>
…p/wire-webapp into feature/backup-encryption
przemvs
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
An attacker with access to the backup file can access all backed up conversations in cleartext. In contrast to the desktop or mobile client, the web client does not offer the possibility to create a password protected or otherwise encrypted backup file.
Solutions
As a defense-in-depth measure, a mechanism for creating a backup file, which is protected by a password or is otherwise encrypted should be offered - as is already available for desktop and mobile clients.
Testing
Test Coverage (Optional)
References