fix: import events without id field #15452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #15452 +/- ##
==========================================
+ Coverage 43.32% 43.38% +0.06%
==========================================
Files 647 647
Lines 21831 21833 +2
Branches 5018 5019 +1
==========================================
+ Hits 9458 9473 +15
+ Misses 11154 11134 -20
- Partials 1219 1226 +7 |
aweiss-dev
approved these changes
Jul 11, 2023
src/script/backup/BackupService.ts
Outdated
| ): Promise<number> { | ||
| if (!generateId) { | ||
| await table.bulkAdd(entities); | ||
| return entities.length; | ||
| } | ||
|
|
||
| const ids = entities.map(generateId); | ||
| const ids = entities.map(generateId).filter((id): id is string => id !== undefined); |
There was a problem hiding this comment.
If you want to ensure that if is a string, why don't you check for it instead of undefined?
There was a problem hiding this comment.
Yeah it's either undefined or string in this case so doesn't really matter, but I find your idea more readable, just updated it ;)
thisisamir98
pushed a commit
that referenced
this pull request
Jul 12, 2023
* fix: import events without id field * refactor: CR suggestion
thisisamir98
added a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #15085
There are some types of events like
conversation.member-joinorconversation.member-leavethat do not contain"id"."id"field was typed as mandatory, while it was not true for mentioned types of events.table.where('id').anyOf(ids).toArray()was throwing error when the list ofidscontained at least oneundefinedvalue.The fix is to type id as optional and filter out the events that do not contain id.