Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user supported protocols #15496

Merged
merged 9 commits into from
Jul 26, 2023
Merged

feat: user supported protocols #15496

merged 9 commits into from
Jul 26, 2023

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented Jul 24, 2023

Adds support for the list of supported protocols on user. It was part of this PR #15247 first, but decided to move it here not to make that one too big.

This PR also adds SelfRepository that contains the logic related with self user - it's consuming self service, similarly as UserRepository consumes userService etc. SelfRepository contains the logic of updating the list of supported protocols of the self user.

Since we don't want to have this functionality on prod, updating the list of self supported protocols is hidden under the feature flag.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #15496 (a6a74c2) into dev (33d804f) will increase coverage by 0.19%.
Report is 14 commits behind head on dev.
The diff coverage is 64.02%.

@@            Coverage Diff             @@
##              dev   #15496      +/-   ##
==========================================
+ Coverage   43.43%   43.62%   +0.19%     
==========================================
  Files         649      653       +4     
  Lines       22086    22241     +155     
  Branches     5051     5080      +29     
==========================================
+ Hits         9593     9703     +110     
- Misses      11260    11296      +36     
- Partials     1233     1242       +9     

@PatrykBuniX PatrykBuniX marked this pull request as ready for review July 24, 2023 13:26
@PatrykBuniX PatrykBuniX requested review from a team and otto-the-bot as code owners July 24, 2023 13:26
@PatrykBuniX PatrykBuniX merged commit ab97daa into dev Jul 26, 2023
13 checks passed
@PatrykBuniX PatrykBuniX deleted the feat/supported-protocols branch July 26, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants