feat: introduce variations to fail to add users (WPB-2299) #15497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #15497 +/- ##
=======================================
Coverage 43.43% 43.44%
=======================================
Files 649 649
Lines 22076 22092 +16
Branches 5048 5052 +4
=======================================
+ Hits 9588 9597 +9
- Misses 11255 11263 +8
+ Partials 1233 1232 -1 |
V-Gira
commented
Jul 24, 2023
Comment on lines
143
to
-125
| {isOpen && ( | ||
| <> | ||
| {total <= 1 && ( |
There was a problem hiding this comment.
condition isOpen is true when total > 1 so this will never happen
V-Gira
commented
Jul 24, 2023
| @@ -49,6 +55,7 @@ const config = Config.getConfig(); | |||
| const FailedToAddUsersMessage: React.FC<FailedToAddUsersMessageProps> = ({ | |||
| isMessageFocused, | |||
| message, | |||
| errorMessageType = ErrorMessageType.offlineBackEnd, | |||
There was a problem hiding this comment.
The different error messages are not part of the scope of the September release.
The only error message displayed stays the same as offline back-end
przemvs
approved these changes
Jul 24, 2023
PatrykBuniX
reviewed
Jul 24, 2023
Comment on lines
+111
to
+132
| {total <= 1 && ( | ||
| <p data-uie-name="1-user-not-added-details" data-uie-value={users[0].id}> | ||
| <span | ||
| css={warning} | ||
| dangerouslySetInnerHTML={{ | ||
| __html: t(`failedToAddParticipantSingularOfflineBackEnd`, { | ||
| name: users[0].name(), | ||
| domain: users[0].domain, | ||
| }), | ||
| }} | ||
| /> | ||
| {learnMore} | ||
| </p> | ||
| )} | ||
| {total > 1 && ( | ||
| <p | ||
| css={warning} | ||
| dangerouslySetInnerHTML={{ | ||
| __html: t(`failedToAddParticipantsPlural`, {total: total.toString()}), | ||
| }} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
Could be simplified to just total <= 1 ? () : (), no?
There was a problem hiding this comment.
It could, I kept it the way @thisisamir98 did it.
Probably easier to read?
There was a problem hiding this comment.
The result will be the same, I'm fine with it
PatrykBuniX
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
errorMesssageprop to thefailedToAddUsercomponent