Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android outlook integration [WPB-3493] #15502

Merged
merged 3 commits into from
Aug 23, 2023
Merged

fix: android outlook integration [WPB-3493] #15502

merged 3 commits into from
Aug 23, 2023

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented Jul 25, 2023 •
edited by github-actions bot
Loading

BugWPB-3493 Calendar: Android outlook internal browser does not support Wire to allow integration

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

add missing browser support for android

@tlebon tlebon requested review from a team and otto-the-bot as code owners July 25, 2023 15:10
@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #15502 (a213a99) into dev (aece143) will decrease coverage by 0.03%.
Report is 125 commits behind head on dev.
The diff coverage is 0.00%.

❗ Current head a213a99 differs from pull request most recent head 56470a2. Consider uploading reports for the commit 56470a2 to get more accurate results

@@            Coverage Diff             @@
##              dev   #15502      +/-   ##
==========================================
- Coverage   43.44%   43.41%   -0.03%     
==========================================
  Files         649      649              
  Lines       22092    22105      +13     
  Branches     5052     5053       +1     
==========================================
  Hits         9597     9597              
- Misses      11263    11276      +13     
  Partials     1232     1232

PatrykBuniX
PatrykBuniX reviewed Jul 26, 2023
View reviewed changes
src/script/auth/module/action/RuntimeAction.ts Outdated
return Runtime.isMobileOS() && (Runtime.isSafari() || Runtime.isChrome());
return (
Runtime.isMobileOS() &&
(Runtime.isSafari() || Runtime.isChrome() || Runtime.getBrowserName() === 'android browser')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe have a constant var for 'android browser' in case it ever changes.

@tlebon tlebon enabled auto-merge (squash) August 23, 2023 09:25
@tlebon tlebon merged commit 1529aa2 into dev Aug 23, 2023
9 checks passed
@tlebon tlebon deleted the fix/android-outlook-integration branch August 23, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykBuniX PatrykBuniX PatrykBuniX approved these changes

@thisisamir98 thisisamir98 thisisamir98 approved these changes

@V-Gira V-Gira V-Gira approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
👕 size: XS type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tlebon @PatrykBuniX @thisisamir98 @V-Gira @otto-the-bot