Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message details click closes right panel if clicked on new details button #15539

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

arjita-mitra
Copy link
Contributor

@arjita-mitra arjita-mitra commented Aug 2, 2023

… details button


PR Submission Checklist for internal contributors

  • The PR Title
    -[web] message details click closes right panel if clicked on new details button

  • The PR Description

    • Current Behavior:

      If you click on the details button in the context menu for reactions it opens up the side panel with details about reacters/viewers.

      if you click on a details button for a second message it closes the right panel

      Expected Behavior:
      The click on a new details button will open the details panel for that message.

Solution:

toggleRightSidebar function has a compareEntityId flag, it should set to be true then comparing of current panel id with the incoming panel id works and returns isDifferentId boolean. based on this we should call the closeSidebar function.

const isDifferentId = compareEntityId && currentEntity?.id !== params?.entity?.id;

References
  1. https://wearezeta.atlassian.net/browse/WPB-3532

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #15539 (241b6fa) into dev (7bec579) will increase coverage by 0.00%.
Report is 22 commits behind head on dev.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev   #15539   +/-   ##
=======================================
  Coverage   43.62%   43.62%           
=======================================
  Files         653      653           
  Lines       22241    22240    -1     
  Branches     5080     5080           
=======================================
  Hits         9703     9703           
+ Misses      11296    11295    -1     
  Partials     1242     1242           

@atomrc atomrc changed the title fix: [web] message details click closes right panel if clicked on new… fix: [web] message details click closes right panel if clicked on new details button Aug 3, 2023
@arjita-mitra arjita-mitra changed the title fix: [web] message details click closes right panel if clicked on new details button fix: message details click closes right panel if clicked on new details button Aug 3, 2023
@arjita-mitra arjita-mitra merged commit 2fa010b into dev Aug 3, 2023
17 checks passed
@arjita-mitra arjita-mitra deleted the bugfix/WPB-3532 branch August 3, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants