fix: message details click closes right panel if clicked on new details button #15539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… details button
PR Submission Checklist for internal contributors
The PR Title
-[web] message details click closes right panel if clicked on new details button
The PR Description
Current Behavior:
If you click on the details button in the context menu for reactions it opens up the side panel with details about reacters/viewers.
if you click on a details button for a second message it closes the right panel
Expected Behavior:
The click on a new details button will open the details panel for that message.
Solution:
toggleRightSidebar function has a compareEntityId flag, it should set to be true then comparing of current panel id with the incoming panel id works and returns isDifferentId boolean. based on this we should call the closeSidebar function.
const isDifferentId = compareEntityId && currentEntity?.id !== params?.entity?.id;
References