Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove devices panel from group convos [WPB-3931] #15610

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix: remove devices panel from group convos [WPB-3931] #15610

merged 1 commit into from
Aug 17, 2023

Conversation

tlebon
Copy link
Contributor

@tlebon tlebon commented Aug 17, 2023 •
edited by github-actions bot
Loading

BugWPB-3931 [Web] Device list of group participant is accessible from conversation details

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Device list doesnt make sense for group convo sidebar as it just shows the first users device.

@tlebon tlebon requested review from otto-the-bot and a team as code owners August 17, 2023 13:55
@tlebon tlebon enabled auto-merge August 17, 2023 13:56
@tlebon tlebon merged commit 346cd3a into dev Aug 17, 2023
9 checks passed
@tlebon tlebon deleted the fix/devices-panel-in-group-chats branch August 17, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomrc atomrc atomrc approved these changes

@przemvs przemvs przemvs approved these changes

@arjita-mitra arjita-mitra arjita-mitra approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
👕 size: XS type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tlebon @atomrc @przemvs @arjita-mitra @otto-the-bot