fix: issue with login not updating #15761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #15761 +/- ##
==========================================
- Coverage 44.48% 44.48% -0.01%
==========================================
Files 672 672
Lines 22703 22706 +3
Branches 5167 5168 +1
==========================================
Hits 10100 10100
- Misses 11314 11317 +3
Partials 1289 1289 📢 Have feedback on the report? Share it here. |
PatrykBuniX
reviewed
Sep 8, 2023
| conversationError, | ||
| }: Props & ConnectedProps & DispatchProps) => { | ||
| const nameInput = React.useRef<HTMLInputElement>(null); | ||
| const {formatMessage: _} = useIntl(); | ||
| const [isLoggedIn, setIsLoggedIn] = useState<boolean>(); |
There was a problem hiding this comment.
suggestion(non-blocking): Let's add false as initial value, this will make isLoggedIn type boolean instead of boolean | undefined.
tlebon
force-pushed
the
fix/join-page-login-status
branch
from
cb78a72
to
95d6d82
Compare
PatrykBuniX
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
missing a useEffect to update login status on new conversation join page.
Checklist