feat: handle connection requests errors (WPB-4418) #15783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V-Gira
commented
Sep 11, 2023
| "modalUserCannotBeAddedHeadline": "Guests cannot be added", | ||
| "modalUserCannotConnectLegalHoldHeadline": "Cannot connect to this user", |
There was a problem hiding this comment.
The localization team requested to change this title for the no-longer-federating case.
We are using the new copy "Connecting not possible" as a title for every case
V-Gira
commented
Sep 11, 2023
Comment on lines
+346
to
+350
| default: { | ||
| PrimaryModal.show(PrimaryModal.type.ACKNOWLEDGE, { | ||
| text: { | ||
| title: t('modalUserCannotConnectHeadline'), | ||
| }, |
There was a problem hiding this comment.
this shows a modal with no message, only the title "Connecting not possible" as a fallback for unhandled cases
There was a problem hiding this comment.
Doesn't it Look weird if the modal doesn't have a message?
There was a problem hiding this comment.
looks fine to me, wdyt?
Codecov Report
@@ Coverage Diff @@
## dev #15783 +/- ##
==========================================
- Coverage 44.48% 44.47% -0.01%
==========================================
Files 672 672
Lines 22707 22714 +7
Branches 5168 5169 +1
==========================================
+ Hits 10101 10103 +2
- Misses 11317 11321 +4
- Partials 1289 1290 +1 |
aweiss-dev
approved these changes
Sep 11, 2023
atomrc
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are not currently giving any feedback to the user if there's any error when sending / ignoring / canceling / accepting connection requests.
Other platforms have a generic error message (iOS), a toast for the different cases (android)
The decision (see ticket) was to use Androids error message in a modal
Screenshots/Screencast (for UI changes)
Checklist